Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use node 16 in upgrade workflows #4177

Merged
merged 1 commit into from
Jul 13, 2023
Merged

chore: use node 16 in upgrade workflows #4177

merged 1 commit into from
Jul 13, 2023

Conversation

iliapolo
Copy link
Contributor

Our dependencies are starting to reject node 14.

yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
error @typescript-eslint/eslint-plugin@[6](https://github.com/aws/jsii/actions/runs/5532321392/jobs/10105940432#step:8:7).0.0: The engine "node" is incompatible with this module. Expected version "^16.0.0 || >=18.0.0". Got "14.21.3"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@iliapolo iliapolo requested a review from a team July 13, 2023 09:49
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Merging (with squash)...

@mergify mergify bot merged commit 2b66bcf into main Jul 13, 2023
23 checks passed
@mergify mergify bot deleted the epolon/node-16-for-upgrade branch July 13, 2023 10:58
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iliapolo @RomainMuller